Velocity Reviews - Computer Hardware Reviews

Velocity Reviews > Newsgroups > Programming > Python > request for another code review

Reply
Thread Tools

request for another code review

 
 
Littlefield, Tyler
Guest
Posts: n/a
 
      09-22-2012
Hello all:
I've gotten a bit farther into my python mud, and wanted to request
another code review for style and the like. Mainly I'm concerned about
player.py, world.py and components and other ways to handle what I'm
trying to do.
I didn't run pychecker just yet, so there are probably a ton of syntax
errors; my problem was that world was importing room, and room imported
world for functionality and that made things a mess.
Ideas and suggestions for code cleanup and cleaner ways to do things
would be appreciated.
git clone https://code.google.com/p/pymud/
Thanks,

--
Take care,
Ty
http://tds-solutions.net
The aspen project: a barebones light-weight mud engine:
http://code.google.com/p/aspenmud
He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.

 
Reply With Quote
 
 
 
 
alex23
Guest
Posts: n/a
 
      09-24-2012
On Sep 23, 6:14*am, "Littlefield, Tyler" <(E-Mail Removed)> wrote:
> I've gotten a bit farther into my python mud, and wanted to request
> another code review for style and the like.


Are you familiar with codereview.stackexchange.com ?

(This isn't to dissuade you from posting such requests here, just to
help increase the chance of eyeballs on your code.)
 
Reply With Quote
 
 
 
 
Littlefield, Tyler
Guest
Posts: n/a
 
      09-24-2012
On 9/23/2012 9:48 PM, alex23 wrote:
> On Sep 23, 6:14 am, "Littlefield, Tyler" <(E-Mail Removed)> wrote:
>> I've gotten a bit farther into my python mud, and wanted to request
>> another code review for style and the like.

> Are you familiar with codereview.stackexchange.com ?


> I actually wasn't, thanks!


> (This isn't to dissuade you from posting such requests here, just to
> help increase the chance of eyeballs on your code.)



--
Take care,
Ty
http://tds-solutions.net
The aspen project: a barebones light-weight mud engine:
http://code.google.com/p/aspenmud
He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.

 
Reply With Quote
 
Littlefield, Tyler
Guest
Posts: n/a
 
      09-24-2012
On 9/23/2012 9:48 PM, alex23 wrote:
> On Sep 23, 6:14 am, "Littlefield, Tyler" <(E-Mail Removed)> wrote:
>> I've gotten a bit farther into my python mud, and wanted to request
>> another code review for style and the like.

> Are you familiar with codereview.stackexchange.com ?


> I actually wasn't, thanks!


> (This isn't to dissuade you from posting such requests here, just to
> help increase the chance of eyeballs on your code.)



--
Take care,
Ty
http://tds-solutions.net
The aspen project: a barebones light-weight mud engine:
http://code.google.com/p/aspenmud
He that will not reason is a bigot; he that cannot reason is a fool; he that dares not reason is a slave.

 
Reply With Quote
 
 
 
Reply

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
What is code review? (Java code review) www Java 51 05-15-2007 01:10 PM
Code Review Request pitoniakm@msn.com Java 2 06-30-2005 02:26 PM
Request for Code Review Ben Hanson C++ 19 07-03-2004 11:27 PM
Request for code review P Kenter C++ 4 06-02-2004 05:26 PM
Re: Accessing Request.InputStream / Request.BinaryRead *as the request is occuring*: How??? Brian Birtle ASP .Net 2 10-16-2003 02:11 PM



Advertisments