«

This simple script works first time but if you click a second time on
the button nothing happens. I expected that the roll function would be
executed again but it doesn't. Could someone explain why.

http://members.chello.at/stephen.jou...hotspots1.html

javascript is at
http://members.chello.at/stephen.jou...e/hotspots1.js

Thanks in advance

Steve meinte:
> This simple script works first time but if you click a second time on
> the button nothing happens. I expected that the roll function would be
> executed again but it doesn't. Could someone explain why.
>
> http://members.chello.at/stephen.jou...hotspots1.html
>
> javascript is at
> http://members.chello.at/stephen.jou...e/hotspots1.js
>
> Thanks in advance

You are constantly pushing values onto the rolls array, and feeding the
output always with the same first few entries. A quick run with a
debugger (e.g. Firebug) would have revealed the problem.

A

rolls = [];

at the beginning of the roll function should suffice. (The rest of the
code is ..er... could be better.)

Gregor

"Steve" <> wrote in message
news:24fa0$4925cfd0$3eb29844$. ..
> This simple script works first time but if you click a second time on the
> button nothing happens. I expected that the roll function would be
> executed again but it doesn't. Could someone explain why.

It is being executed again. You are just putting exactly the same numbers
back there.

Steve meinte:
> On Nov 20, 10:59 pm, Gregor Kofler <use...@gregorkofler.at> wrote:

>> (The rest of the code is ..er... could be better.)
>
> It is obvious that I am self-learned, mainly from this forum and the
> Oreilly Rhino book. So I would be grateful if you could give a little
> more detail of how the code could be improved, or how you would have
> written the code, in order that I can improve my javascript abilities.

Not tested:

function roll() {
var rows = 2, cols = 5, sum, v, c, r,
table = getElementsByTagName("table")[0];
for(c = cols; c-- {
sum = 0;
for(r = rows; r-- {
v = Math.ceil(Math.random()*6);
sum += v;
// innerHTML is not standardized
table.rows[r].cells[c].innerHTML = v;
}
table.rows[rows].cells[c].innerHTML = sum;
}
}

Gregor

In comp.lang.javascript message <03a27cb9-8dc5-4073-baca-502b0347ea99@v1
3g2000yqm.googlegroups.com>, Fri, 21 Nov 2008 01:33:11, Steve
<> posted:

>It is obvious that I am self-learned, mainly from this forum and the
>Oreilly Rhino book.

Please do not give ambiguous references.

--
(c) John Stockton, nr London UK. replyYYWW merlyn demon co uk Turnpike 6.05.
Web <URL:http://www.uwasa.fi/~ts/http/tsfaq.html> -> Timo Salmi: Usenet Q&A.
Web <URL:http://www.merlyn.demon.co.uk/news-use.htm> : about usage of News.
No Encoding. Quotes precede replies. Snip well. Write clearly. Mail no News.

In comp.lang.javascript message <UuwVk.8$>,
Fri, 21 Nov 2008 11:57:56, Gregor Kofler <>
posted:

> v = Math.ceil(Math.random()*6);

Code containing such a line is unlikely to be correct, but the fault
will not be found with inadequate testing. Read the FAQ; or think.

--
(c) John Stockton, nr London UK. ?@merlyn.demon.co.uk IE7 FF2 Op9 Sf3
news:comp.lang.javascript FAQ <URL:http://www.jibbering.com/faq/index.html>.
<URL:http://www.merlyn.demon.co.uk/js-index.htm> jscr maths, dates, sources.
<URL:http://www.merlyn.demon.co.uk/> TP/BP/Delphi/jscr/&c, FAQ items, links.

Dr J R Stockton meinte:
> In comp.lang.javascript message <UuwVk.8$>,
> Fri, 21 Nov 2008 11:57:56, Gregor Kofler <>
> posted:
>
>> v = Math.ceil(Math.random()*6);
>
> Code containing such a line is unlikely to be correct, but the fault
> will not be found with inadequate testing. Read the FAQ; or think.
>
Interesting. In what respect is this code unlikely to be correct? Or
rather, how do you infer that the rest of the code must be crap, if it
contains such a line? Let's see: 2 static methods, a multiplication,
result assigned to a local variable. Could you shed some light on the
issues?

Gregor

On Nov 22, 2:28*pm, Gregor Kofler <use...@gregorkofler.at> wrote:
> Dr J R Stockton meinte:> In comp.lang.javascript message <UuwVk.8$577...@nntpserver.swip.net>,
> > Fri, 21 Nov 2008 11:57:56, Gregor Kofler <use...@gregorkofler.at>
> > posted:
>
> >> * * *v = Math.ceil(Math.random()*6);
>
> > Code containing such a line is unlikely to be correct, but the fault
> > will not be found with inadequate testing. *Read the FAQ; or think.
>
> Interesting. In what respect is this code unlikely to be correct? Or

If the Math.random call returns 0.

[snip]

David Mark meinte:
> On Nov 22, 2:28 pm, Gregor Kofler <use...@gregorkofler.at> wrote:
>> Dr J R Stockton meinte:> In comp.lang.javascript message <UuwVk.8$577...@nntpserver.swip.net>,
>>> Fri, 21 Nov 2008 11:57:56, Gregor Kofler <use...@gregorkofler.at>
>>> posted:
>>>> v = Math.ceil(Math.random()*6);
>>> Code containing such a line is unlikely to be correct, but the fault
>>> will not be found with inadequate testing. Read the FAQ; or think.
>> Interesting. In what respect is this code unlikely to be correct? Or
>
> If the Math.random call returns 0.

Ah, damn. Right. Yes, floor() + 1 is definitely the better solution.


Gregor

Gregor Kofler wrote:
> Dr J R Stockton meinte:
>> In comp.lang.javascript message <UuwVk.8$>,
>> Fri, 21 Nov 2008 11:57:56, Gregor Kofler <>
>> posted:
>>
>>> v = Math.ceil(Math.random()*6);
>>
>> Code containing such a line is unlikely to be correct, but the fault
>> will not be found with inadequate testing. Read the FAQ; or think.
>>
> Interesting. In what respect is this code unlikely to be correct?

Well its an odd thing, but its one way of rolling a pseudorandom die, I
suppose..


Or
> rather, how do you infer that the rest of the code must be crap, if it
> contains such a line? Let's see: 2 static methods, a multiplication,
> result assigned to a local variable. Could you shed some light on the
> issues?
>

I suspect he couldn't see the point of a random integer between one and
six..


> Gregor