«

Matt Kruse wrote on 27 okt 2005 in comp.lang.javascript:

> Evertjan. wrote:
>>> function toggleTable(id){
>>> var tables = document.getElementsByTagName('table');
>>> for(i in tables) tables[i].className = 't';
>>> document.getElementById(id).className = '';
>>> }
>
> Setting a classname on a table is much slower than setting individual
> attributes, since the browser needs to re-compute all the nested tags'
> styles. It may or may not be the best route, depending on the
> situation.
>
>> Even nicer, IMHO:
>> function toggleTable(id){
>> var tables = document.getElementsByTagName('table');
>> for(i in tables)
>> tables[i].className = (tables[i].id!=id)?'t':'';
>> }
>
> Unless you are confident that your markup will never change, setting
> the value of className should be avoided, IMO. You should always add a
> classname from the space-separated list or remove it. That way, if
> your table has a class of "data" it would become "data t" rather than
> losing the "data" class entirely. Then the code becomes more portable
> and generalized.
>

I am sure you are right, Mat.

I like programming for fun and visual elegance,
that is why I wrote "nicer", not "better".

In general, getElementsByTagName is also not safe in the sense that later
alterations won't lead to coding bugs, and the best is id-ing all
elements that need to be addressed by one's code.

However the class="data t" is rumored not to be cross browser compatible?

--
Evertjan.
The Netherlands.
(Replace all crosses with dots in my emailaddress)

Evertjan. wrote:
> However the class="data t" is rumored not to be cross browser
> compatible?

Not in any recent browsers that I know of. It's definitely part of CSS
specs.
Netscape 4 didn't like it, iirc, but who cares?

--
Matt Kruse
http://www.JavascriptToolbox.com
http://www.AjaxToolbox.com

On 27/10/2005 20:33, Matt Kruse wrote:

> Evertjan. wrote:
>
>> However the class="data t" is rumored not to be cross browser
>> compatible?
>
> Not in any recent browsers that I know of. It's definitely part of CSS
> specs.

And HTML, which is where it matters.

CSS itself has its own, related issue where multiple class names are
used in a selector. That is:

.class1.class2 {
/* ... */
}

Even IE6 gets this wrong; it considers the last class name only.

> Netscape 4 didn't like it, iirc, but who cares?

Neither does IE4, and I share your sentiment. After all, CSS only
provides presentation suggestions.

Mike

--
Michael Winter
Prefix subject with [News] before replying by e-mail.

Michael Winter wrote on 27 okt 2005 in comp.lang.javascript:

> Even IE6 gets this wrong; it considers the last class name only.
>
>> Netscape 4 didn't like it, iirc, but who cares?
>
> Neither does IE4, and I share your sentiment. After all, CSS only
> provides presentation suggestions.
>

I will start using it again.

--
Evertjan.
The Netherlands.
(Replace all crosses with dots in my emailaddress)