«

I'm using Active state 5.8 and writing for windows. I have a very
simple parser that writes a csv file (Comma separated Values). It
looks like this:

eval{
open APOUT, ">APresults.csv" || die "Can't open file
APresults.csv!";
foreach my $seqID (keys %hashRef){

if (grep {$_ eq $seqID} @SNPlower){

print APOUT
"$hashRef{$seqID}{PNLNUM},$seqID,$hashRef{$seqID}{ SBEStrand},$hashRef{$seqID}{SBE},$hashRef{$seqID}{ WARN}";
print APOUT "\n";
}

}
close APOUT;
};

if ($@){
print $@;
}

I noticed when I accidentally had the file APresults.csv open I get
this:

print() on closed filehandle APOUT at APResults parse.pl line 101, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 102, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 101, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 102, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 101, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 102, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 101, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 102, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 101, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 102, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 101, <>
line 230.
print() on closed filehandle APOUT at APResults parse.pl line 102, <>
line 230.

which is exactly how many times I call the print statement in the loop.
My question is if the file can't be opened because its busy with
another process, shouldn't the open just die?

wrote in
news: ups.com:

> I'm using Active state 5.8 and writing for windows. I have a very
> simple parser that writes a csv file (Comma separated Values). It
> looks like this:
>
> eval{
> open APOUT, ">APresults.csv" || die "Can't open file
> APresults.csv!";

You should include the reason why the file could not be opened in the
error message. Also, you have used || in the call above. It will never
die.

open my $apout, '>', 'APresults.csv'
or die "Can't open 'APresults.csv': $!";

If you want to use ||, then you should properly paranthesize the open
call:

open(my $apout, '>', 'APresults.csv')
|| die "Can't open 'APresults.csv': $!";

....

> if ($@){
> print $@;
> }

IMNSHO, it is better to write error messages to stderr. In fact, given
your script, I would just use:

die $@ if $@;
....

Sinan

--
A. Sinan Unur <>
(reverse each component and remove .invalid for email address)

comp.lang.perl.misc guidelines on the WWW:
http://mail.augustmail.com/~tadmc/cl...uidelines.html

A. Sinan Unur wrote:
> wrote in
> news: ups.com:
>
> > I'm using Active state 5.8 and writing for windows. I have a very
> > simple parser that writes a csv file (Comma separated Values). It
> > looks like this:
> >
> > eval{
> > open APOUT, ">APresults.csv" || die "Can't open file
> > APresults.csv!";
>
> You should include the reason why the file could not be opened in the
> error message. Also, you have used || in the call above. It will never
> die.
>
> open my $apout, '>', 'APresults.csv'
> or die "Can't open 'APresults.csv': $!";
>
> If you want to use ||, then you should properly paranthesize the open
> call:
>
> open(my $apout, '>', 'APresults.csv')
> || die "Can't open 'APresults.csv': $!";
>
> ...
>
> > if ($@){
> > print $@;
> > }
>
> IMNSHO, it is better to write error messages to stderr. In fact, given
> your script, I would just use:
>
> die $@ if $@;
> ...
>
> Sinan

Thanks for the advice!