«

In general, which "if" is better practice?
Or does it depend on what you'd like to do?
Or it doesn't matter; it's a matter of taste?


I think both of these do the same.

=======================================
$test = checkMe($var);
if ($test eq "good") {
#pass
}


=======================================

if (checkMe($var) eq "good") {
#pass
}


=======================================

checkMe() is a pseudo function

On Tue, 13 Jul 2004 03:49:29 -0400, Ken Sington
<ken_sington@nospam_abcdefg.com> wrote:

> In general, which "if" is better practice?
> Or does it depend on what you'd like to do?
> Or it doesn't matter; it's a matter of taste?

It's probably a matter of taste.


[...]
> =======================================
>
> if (checkMe($var) eq "good") {
> #pass
> }

I prefer this one, as it's easier to read what the
test is all about.

You know, this isn't really a Perl question...


[...]


--
It's not a bug, it's the future.

Ken Sington <ken_sington@nospam_abcdefg.com> wrote in comp.lang.perl.misc:
> In general, which "if" is better practice?
> Or does it depend on what you'd like to do?
> Or it doesn't matter; it's a matter of taste?
>
>
> I think both of these do the same.

They do.

> =======================================
> $test = checkMe($var);
> if ($test eq "good") {
> #pass
> }
>
>
> =======================================
>
> if (checkMe($var) eq "good") {
> #pass
> }
>
>
> =======================================

If you need the result of checkMe() again, use the variable. If you
don't, don't.

Anno

Ken Sington wrote:

> if (checkMe($var) eq "good") {
> #pass
> }

I would go with this as there is no other use for the surrogate $test variable.

But both are good.

On Tue, 13 Jul 2004 03:49:29 -0400, Ken Sington wrote:
> I think both of these do the same.

They do, actually.

> $test = checkMe($var);
> if ($test eq "good") {
> #pass
> }
>
> if (checkMe($var) eq "good") {
> #pass
> }

If you need '$test' later in your script, use the first one. If not,
you're better off with the last suggestion.


--
Tore Aursand <>
"If your project doesn't work, look for the part that you didn't think
was important." (Arthur Bloch)

Tore Aursand wrote:
> On Tue, 13 Jul 2004 03:49:29 -0400, Ken Sington wrote:
>> I think both of these do the same.
>
> They do, actually.
>
>> $test = checkMe($var);
>> if ($test eq "good") {
>> #pass
>> }
>>
>> if (checkMe($var) eq "good") {
>> #pass
>> }
>
> If you need '$test' later in your script, use the first one. If not,
> you're better off with the last suggestion.

Agreed. Plus, if checkMe() isn't a true function but has side effects then
you may not be able to call checkMe() twice without undesirable results.

jue

Ken Sington <ken_sington@nospam_abcdefg.com> wrote:
> In general, which "if" is better practice?
> Or does it depend on what you'd like to do?
> Or it doesn't matter; it's a matter of taste?
>
> I think both of these do the same.
>
> =======================================
> $test = checkMe($var);
> if ($test eq "good") {
> #pass
> }

Ok, now I'm left hanging, thinking "Where is he going to use the value
stuffed into this $test variable again?"

Also, you don't seem to be using strict!

>
> =======================================
>
> if (checkMe($var) eq "good") {
> #pass
> }

This is tidy, and is a better practise. (Unless, of course, you *are*
going to use $test later on)

Xho

--
-------------------- http://NewsReader.Com/ --------------------
Usenet Newsgroup Service $9.95/Month 30GB

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2004-07-13, Ken Sington <ken_sington@nospam_abcdefg.com> wrote:

> Or does it depend on what you'd like to do?

It looks like the answer is "it depends".

> if (checkMe($var) eq "good") {
> #pass
> }

I too do the above, unless I need the value of checkMe($var)
later.

- --keith

- --
kkeller-
(try just my userid to email me)
AOLSFAQ=http://wombat.san-francisco.ca.us/cgi-bin/fom

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFA9At5hVcNCxZ5ID8RAtMvAKCb/PMkTMrjS4Q3WV4GJngrnr0AZACfbHvj
coRXuA7DDFcmx2Yx2g8EENM=
=wqZ5
-----END PGP SIGNATURE-----

In article <9IudnRwShYmVCW7dRVn->,
Ken Sington <ken_sington@nospam_abcdefg.com> wrote:

> In general, which "if" is better practice?
[snip]
> $test = checkMe($var);
> if ($test eq "good") {
> #pass
> }
vs.
> if (checkMe($var) eq "good") {
> #pass
> }

It depends. Simple is always good, so if you have no need for the
'$test' value except in the if statement, I find the latter easier to
read.

OTOH, if you plan to actually do something with '$test' other than a
mere eq test, the temporary variable saves needing to do the same
computation twice.

HTH,
Ricky

Abigail wrote:
> Ken Sington (ken_sington@nospam_abcdefg.com) wrote on MMMCMLXIX September
MMMCMLXIX$%@!!@&!!

> \\ In general, which "if" is better practice?
>
> Pointless question. If you don't have a measurement what's the point
ok, it must be specific than general.
It seems perl folks have different standards.
Like really short code that fits in a single screen.

> of talking about "better"? Better by what standard? Less keystrokes?
> Quicker to compile? Quicker to run? Easier to understand? By whom?
.... so like instead of
$x = 1 + 1;
$x = fnct1($x);
$x = hex ($x);

I notice in some perl code:
hex (fnct1(1 + 1));

I think its easier to work with (or upgrade) muliple line format code.

....


> - What the phase of the moon is.
what is the phase of the moon in mongolia?
>
>
> Abigail