«

I have a simple demo program that demonstates use of recursion ( on linux )
The problem is that it does not work for "long" integers. I assume this is a problem with printf

I tried %l instead of %d but that doesnot print any integer.

########## This is fine
../fib 10000
50005000

######### Oops this is not working
../fib 100000
705082704


----------------
#include <stdio.h>
#include <stdlib.h>
long fibonacci(long n) {
return ((n == 1 ) ? 1 : (n + (fibonacci(n - 1 ))));
}
int main(int argc , char *argv[]) {
long n = atol(argv[1]);
printf("%d\n",fibonacci(n));
}

Ram Prasad <> wrote:
> I have a simple demo program that demonstates use of recursion ( on linux )
> The problem is that it does not work for "long" integers. I assume this is a problem with printf

> I tried %l instead of %d but that doesnot print any integer.

You need "%ld".
Regards, Jens
--
\ Jens Thoms Toerring ___
\__________________________ http://toerring.de

Ram Prasad <> writes:

> I have a simple demo program that demonstates use of recursion ( on
> linux ) The problem is that it does not work for "long" integers. I
> assume this is a problem with printf
>
> I tried %l instead of %d but that doesnot print any integer.

You need %ld. The 'l' is a length modifier not a conversion character.

> ########## This is fine
> ./fib 10000
> 50005000

That's not fine -- fib(10000) is over 2000 digits long! The code will
reveal all...

> ######### Oops this is not working
> ./fib 100000
> 705082704
>
>
> ----------------
> #include <stdio.h>
> #include <stdlib.h>
> long fibonacci(long n) {
> return ((n == 1 ) ? 1 : (n + (fibonacci(n - 1 ))));
> }

This is not the Fibonacci function. It sums the numbers less that n.
None the less, you have still come up against the fact that C's long
type does not have to be able to hold numbers any bigger than
2147483647.

> int main(int argc , char *argv[]) {
> long n = atol(argv[1]);
> printf("%d\n",fibonacci(n));
> }

To calculate large Fibonacci numbers you need to use a library that
gives you "big nums" like gmp or you need to switch to one of the many
languages that provide such things "built in". Note also that the
"obvious" recursive algorithm for Fibonacci numbers is very inefficient.

--
Ben.

On Mon, 2011-02-07, Jens Thoms Toerring wrote:
> Ram Prasad <> wrote:
>> I have a simple demo program that demonstates use of recursion ( on linux )
>> The problem is that it does not work for "long" integers. I assume this is a problem with printf
>
>> I tried %l instead of %d but that doesnot print any integer.
>
> You need "%ld".

And (since he's on Linux) "man 3 printf" (to learn the rest) and full
warning options to gcc (so he gets told when he makes this mistake).

/Jorgen

--
// Jorgen Grahn <grahn@ Oo o. . .
\X/ snipabacken.se> O o .

On 2011-02-07, Ram Prasad <> wrote:
> I have a simple demo program that demonstates use of recursion ( on linux )
> The problem is that it does not work for "long" integers. I assume this is a problem with printf

No.

> I tried %l instead of %d but that doesnot print any integer.

Try %ld.

-s
--
Copyright 2010, all wrongs reversed. Peter Seebach / usenet-
http://www.seebs.net/log/ <-- lawsuits, religion, and funny pictures
http://en.wikipedia.org/wiki/Fair_Game_(Scientology) <-- get educated!
I am not speaking for my employer, although they do rent some of my opinions.