Velocity Reviews - Computer Hardware Reviews

Velocity Reviews > Newsgroups > Programming > C++ > Code review

Reply
Thread Tools

Code review

 
 
Ebenezer
Guest
Posts: n/a
 
      01-30-2011

I'd like to request comments on the code in the archive on
this page -- http://webEbenezer.net/build_integration.html .
As you may know, I'm working on an on line code generator
that writes C++ marshalling code based on user input. I use
a three-tier architecture as follows:


C++ Middleware Writer (CMW) -- this is a server ... closed source


C++ Middleware Writer Ambassador (CMWA) -- this is a server ... open
source


"direct" program -- this program runs once and exits ... open source


The two open source tiers are in the archive mentioned above along
with supporting files. One of the files in the archive,
msg_shepherd.hh, is output from the CMW. That file is based on
another file in the archive called direct.mdl as well as some include
files.


One thing that I expect will be brought up is that the software
mixes naming conventions. I haven't picked one and been
consistent with it as is sometimes advised. I agree with that advice
for the most part, but have been lazy about following it so far.

There's a mediateResponse function in the CMWA that may
result in comments. Some knowledge of the CMW is needed ---
if the returned transaction number is zero, the value of the request
result (reqResult) will be false. I can only think of things like
sun storms that would cause this to be violated. But it wouldn't
be difficult to add code that checks if returnedTransactionNbr is
zero and reqResult is true and throws an exception.


In the "direct" program the function that connects to the
ambassador uses 127.0.0.1. That needs to be worked on.

The software in the archive has been tested on Linux and Windows.
I'd appreciate advice on improving the existing code as well as
suggestions of new functionality. There are about 3800 lines of
code in the archive. I realize people are busy and most can't
review all of it. If you would review a function or a class that
would be helpful. Thanks in advance.


Brian Wood
Ebenezer Enterprises
http://webEbenezer.net
(651) 251-9384
 
Reply With Quote
 
 
 
 
Ebenezer
Guest
Posts: n/a
 
      01-30-2011
On Jan 30, 10:34*am, Ebenezer <(E-Mail Removed)> wrote:
> I'd like to request comments on the code in the archive on
> this page --http://webEbenezer.net/build_integration.html.
> As you may know, I'm working on an on line code generator
> that writes C++ marshalling code based on user input. * I use
> a three-tier architecture as follows:
>
> C++ Middleware Writer (CMW) *-- *this is a server ... closed source
>
> C++ Middleware Writer Ambassador (CMWA) -- this is a server ... open
> source
>
> "direct" program *-- this program runs once and exits ... open source
>
> The two open source tiers are in the archive mentioned above along
> with supporting files. *One of the files in the archive,
> msg_shepherd.hh, is output from the CMW. *That file is based on
> another file in the archive called direct.mdl as well as some include
> files.
>
>


I was reviewing the code some recently and have a question about
changing my API. In msg_shepherd.hh, there's a function with this
signature:

void
Send(SendCompressedBuffer& buf, const std::vector<cmw_account_info>&
abt1);

I'm considering making the buffer parameter the last one rather
than the first one. My current approach is similar to the
interface of write. Thinking about how fwrite's interface is
different from write's interface made me wonder if I should
change the interface now before it becomes more difficult to
do so in the future. The fwrite interface seems to have a
"who, what, when, where, why, how" approach. The "how" being
via the file handle or buffer in my case. What do you suggest?

 
Reply With Quote
 
 
 
Reply

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
What is code review? (Java code review) www Java 51 05-15-2007 01:10 PM
Secure Python code - volunteers for code review? andrew blah Python 6 10-17-2004 01:17 AM
Re: Secure Python code - volunteers for code review? Josiah Carlson Python 1 10-13-2004 03:05 PM
Code write \ code review productivity Volodymyr Sadovyy Java 8 04-25-2004 03:30 AM
Code review of cross platform code sample Otto Wyss C++ 5 09-07-2003 02:06 PM



Advertisments