«

I have a problem with the .split method. It causes a
NullPointerException when I try to read form a .csv file which has
several lines of comma separated values which I'd like to put into p
[]. The code works fine when I remove the do..while. Do I maybe have
to re-initialise the String[] price somehow? Any advice is
appreciated.

do {
String[] price = new String[1000];
line = buff.readLine();
price = line.toString().split (","); // CAUSING
NullPointerException.
i++;
p[i]=Float.parseFloat(price[4]);
} while (line != null);

NickPick <> writes:
> String[] price = new String[1000];
> line = buff.readLine();

java.lang.System.err.println( line );

> price = line.toString().split (","); // CAUSING
>NullPointerException.
> i++;
> p[i]=Float.parseFloat(price[4]);
> } while (line != null);

NickPick wrote:
> I have a problem with the .split method. It causes a
> NullPointerException when I try to read form a .csv file which has
> several lines of comma separated values which I'd like to put into p
> []. The code works fine when I remove the do..while. Do I maybe have
> to re-initialise the String[] price somehow?

No,

>
> do {
> String[] price = new String[1000];

This initialization is a complete waste, as you throw away the String[1000].

> line = buff.readLine();
> price = line.toString().split (","); // CAUSING
> NullPointerException.

'line' is 'null'.

> i++;
> p[i]=Float.parseFloat(price[4]);

You will have an exception if there are fewer than five Strings in the array.

> } while (line != null);


--
Lew

NickPick wrote:
> do {
> String[] price = new String[1000];
> line = buff.readLine();
> price = line.toString().split (","); // CAUSING
> NullPointerException.
> i++;
> p[i]=Float.parseFloat(price[4]);
> } while (line != null);

This would be the programming equivalent of "Closing the barn door after
the horse has gone." Ignoring a useless initialization, a magic array
access without checking, Usenet formatting errors, and a minor stylistic
complaint, your problem is that you're checking for line being null
after you use it.


--
Beware of bugs in the above code; I have only proved it correct, not
tried it. -- Donald E. Knuth

On 2 Mar 2009 15:09:45 GMT, (Stefan Ram) wrote,
quoted or indirectly quoted someone who said :

>> line = buff.readLine();
>
> java.lang.System.err.println( line );

a null line is how Java tells you about EOF, not an EOFException.
--
Roedy Green Canadian Mind Products
http://mindprod.com

"Learning is not compulsory... neither is survival."
~ Dr. W. (William) Edwards Deming (born: 1900-10-14 died: 1993-12-20 at age: 93))

Op 02-03-09 15:45, schreef NickPick:
> I have a problem with the .split method. It causes a
> NullPointerException when I try to read form a .csv file which has
> several lines of comma separated values which I'd like to put into p
> []. The code works fine when I remove the do..while. Do I maybe have
> to re-initialise the String[] price somehow? Any advice is
> appreciated.
>
> do {
> String[] price = new String[1000];
> line = buff.readLine();
> price = line.toString().split (","); // CAUSING
> NullPointerException.
> i++;
> p[i]=Float.parseFloat(price[4]);
> } while (line != null);

while (null != (line = buff.readLine())) {
String[] price = new String[1000];
//anything you like
//line will never be nill
}