«

"Jim" <> wrote in message
news:dd81c729-01d2-436a-ad00-...
> Hi There,
>
> I'm trying to read a file character by character. When I write the
> file out, there is one extra character which shows on the screen as a
> solid circle with a small question mark in the middle.
>
> Here is what I have:
>
> infile = fopen("encrypted.txt", "r");
> outfile = fopen("plain.txt", "w");

>
> while(!feof(infile)) {

That's the wrong way to use feof() as has been explained.

I found it helpful myself to think of feof() as being named feof_triggered()
instead. So it's not true until an attempt is made to read past EOF.

I also made my own feof() which works the way you and I might expect, but
that involves a lot of bad code using fseeks, ftells and assorted
assumptions, so I won't post it here!

> ch = fgetc(infile);

ch returns an EOF value (usually -1) at the end of file. That's what you
should be looking for. I revised your loop to:

while(1)
{ ch=fgetc(infile);
if (ch==EOF) break;
fputc(ch, outfile);
};

--
Bart

Bartc wrote:
) I also made my own feof() which works the way you and I might expect, but
) that involves a lot of bad code using fseeks, ftells and assorted
) assumptions, so I won't post it here!

What's wrong with using getc() and ungetc() ?

int my_feof(FILE *stream) {
int c = getc(stream);
if (c == EOF) {
if feof(stream) return F_EOF;
if ferror(stream) return F_ERROR;
return F_UNKNOWN;
}
if (ungetc(c, stream) == EOF) return F_UNKNOWN;
return F_OK;
}

Which, I think, should work just dandy.


SaSW, Willem
--
Disclaimer: I am in no way responsible for any of the statements
made in the above text. For all I know I might be
drugged or something..
No I'm not paranoid. You all think I'm paranoid, don't you !
#EOT

"Willem" <> wrote in message
news:...
> Bartc wrote:
> ) I also made my own feof() which works the way you and I might expect,
> but
> ) that involves a lot of bad code using fseeks, ftells and assorted
> ) assumptions, so I won't post it here!
>
> What's wrong with using getc() and ungetc() ?

Well, I never thought of using ungetc(). I've just tried a simplified
version of your code as:

/* Return 1 (true) if positioned at EOF, or on error */
/* Return 0 (false) otherwise */

int pascal_eof(FILE *stream) {
int c = getc(stream);
if (c == EOF) return 1;
if (ungetc(c,stream) == EOF) return 1;
return 0;
}

--
Bart