«

i wanted to know if that's a good design style (upto the knowledge i have
gained till chpater 7):

/* C++ Primer - 4/e
*
* exercise 7.4
* STATEMENT
* write a programme to take two int paramaters and generate the
result of raising the first to the power of the second. write a
programme to call your function passing it two ints. verify the
result.
*
*/

#include <iostream>

int raise_power(int x, int y)
{
int mult = 1;

while( y )
{
mult = mult * x;
--y;
}

return mult;
}

int main()
{
int i = 2;
int j = 3;
int mult_result = 8;

std::cout << static_cast<bool>(mult_result == raise_power(i, j))
<< std::endl;
/* well, never got converted to "true", it alwasy remains 1 */
return 0;
}




--
http://arnuld.blogspot.com

On Aug 8, 9:59 pm, arnuld <geek.arn...@gmail.com> wrote:
> i wanted to know if that's a good design style (upto the knowledge i have
> gained till chpater 7):
>
> /* C++ Primer - 4/e
> *
> * exercise 7.4
> * STATEMENT
> * write a programme to take two int paramaters and generate the
> result of raising the first to the power of the second. write a
> programme to call your function passing it two ints. verify the
> result.
> *
> */
>
> #include <iostream>
>
> int raise_power(int x, int y)

I would suggest using more meaningful variable names other than 'x'
and 'y'. 'base' and 'exponent' come to mind.

> {
> int mult = 1;
>
> while( y )

If 'y' is a negative number (which is allowed since it's defined as an
int), this while condition will cause a major bug n your program.

> {
> mult = mult * x;
> --y;

Your while condition is wrong. But if it was correct, you could have
simply written "while( y-- )" to achieve the same result without the
stand-alone decrement.

> }
>
> return mult;
>
> }
>
> int main()
> {
> int i = 2;
> int j = 3;
> int mult_result = 8;
>
> std::cout << static_cast<bool>(mult_result == raise_power(i, j))
> << std::endl;
> /* well, never got converted to "true", it alwasy remains 1 */
> return 0;
>
> }
>
> --http://arnuld.blogspot.com


Cheers,
Andre

arnuld wrote:
> i wanted to know if that's a good design style (upto the knowledge i have
> gained till chpater 7):
>
> /* C++ Primer - 4/e
> *
> * exercise 7.4
> * STATEMENT
> * write a programme to take two int paramaters and generate the
> result of raising the first to the power of the second. write a
> programme to call your function passing it two ints. verify the
> result.
> *
> */
>
> #include <iostream>
>
> int raise_power(int x, int y)
> {
> int mult = 1;
>
> while( y )
> {
> mult = mult * x;
> --y;
> }
>
> return mult;
> }
>
That's OK for positive numbers, but what about negative?

> int main()
> {
> int i = 2;
> int j = 3;
> int mult_result = 8;
>
> std::cout << static_cast<bool>(mult_result == raise_power(i, j))
> << std::endl;

Be brutal,

assert( raise_power(i, j) == mult_result );

Don't forget to include <cassert>

--
Ian Collins.

> On Aug 9, 10:14 am, Ian Collins <ian-n...@hotmail.com> wrote:
> > arnuld wrote:

> > ...[SNIP]...

> > std::cout << static_cast<bool>(mult_result == raise_power(i, j))
> > << std::endl;


> Be brutal,
>
> assert( raise_power(i, j) == mult_result );
>
> Don't forget to include <cassert>

that raises an error:

/home/arnuld/programming/cpp $ g++ -ansi -pedantic -Wall -Wextra
ex_07-03.cpp
ex_07-03.cpp: In function 'int main()':
ex_07-03.cpp:32: error: no match for 'operator<<' in 'std::cout <<
((raise_power(i, ((unsigned int)j)) != mult_result) ?
__assert_fail(((const char*)"mult_result == raise_power(i, j)"),
((const char*)"ex_07-03.cpp"), 32u, ((const char*)(&
__PRETTY_FUNCTION__))) : 0)'
/usr/lib/gcc/i686-pc-linux-gnu/4.2.1/../../../../include/c++/4.2.1/
ostream:112: note: candidates are: std::basic_ostream<_CharT,
_Traits>& std::basic_ostream<_CharT,
_Traits>:perator<<(std::basic_ostream<_CharT, _Traits>& (*)
(std::basic_ostream<_CharT, _Traits>&)) [with _CharT = char, _Traits =
std::char_traits<char>]


line 32, is where i use "assert".

> On Aug 9, 10:21 am, arnuld <geek.arn...@gmail.com> wrote:
> that raises an error:
>
> /home/arnuld/programming/cpp $ g++ -ansi -pedantic -Wall -Wextra
> ex_07-03.cpp
> ex_07-03.cpp: In function 'int main()':
> ex_07-03.cpp:32: error: no match for 'operator<<' in 'std::cout <<
> ((raise_power(i, ((unsigned int)j)) != mult_result) ?
> __assert_fail(((const char*)"mult_result == raise_power(i, j)"),
> ((const char*)"ex_07-03.cpp"), 32u, ((const char*)(&
> __PRETTY_FUNCTION__))) : 0)'
> /usr/lib/gcc/i686-pc-linux-gnu/4.2.1/../../../../include/c++/4.2.1/
> ostream:112: note: candidates are: std::basic_ostream<_CharT,
> _Traits>& std::basic_ostream<_CharT,
> _Traits>:perator<<(std::basic_ostream<_CharT, _Traits>& (*)
> (std::basic_ostream<_CharT, _Traits>&)) [with _CharT = char, _Traits =
> std::char_traits<char>]
>
> line 32, is where i use "assert".

sorry, forgot to post code:

std::cout << assert(mult_result == raise_power(i, j))
<< std::endl;

arnuld wrote:
>> On Aug 9, 10:21 am, arnuld <geek.arn...@gmail.com> wrote:
>> that raises an error:
>>
>> /home/arnuld/programming/cpp $ g++ -ansi -pedantic -Wall -Wextra
>> ex_07-03.cpp
>> ex_07-03.cpp: In function 'int main()':
>> ex_07-03.cpp:32: error: no match for 'operator<<' in 'std::cout <<
>> ((raise_power(i, ((unsigned int)j)) != mult_result) ?
>> __assert_fail(((const char*)"mult_result == raise_power(i, j)"),
>> ((const char*)"ex_07-03.cpp"), 32u, ((const char*)(&
>> __PRETTY_FUNCTION__))) : 0)'
>> /usr/lib/gcc/i686-pc-linux-gnu/4.2.1/../../../../include/c++/4.2.1/
>> ostream:112: note: candidates are: std::basic_ostream<_CharT,
>> _Traits>& std::basic_ostream<_CharT,
>> _Traits>:perator<<(std::basic_ostream<_CharT, _Traits>& (*)
>> (std::basic_ostream<_CharT, _Traits>&)) [with _CharT = char, _Traits =
>> std::char_traits<char>]
>>
>> line 32, is where i use "assert".
>
> sorry, forgot to post code:
>
> std::cout << assert(mult_result == raise_power(i, j))
> << std::endl;
>
>
No, just use what I wrote.

--
Ian Collins.

> On Aug 9, 11:12 am, Ian Collins <ian-n...@hotmail.com> wrote:

> No, just use what I wrote.


i did use that, now i just modified it to:

std::cout << std::assert( raise_power(i, j) == mult_result )
<< std::endl;

and the error is:

ex_07-03.cpp:32: error: expected unqualified-id before '(' token


what now ?

arnuld wrote:
>> On Aug 9, 11:12 am, Ian Collins <ian-n...@hotmail.com> wrote:
>
>> No, just use what I wrote.
>
>
> i did use that, now i just modified it to:
>
> std::cout << std::assert( raise_power(i, j) == mult_result )
> << std::endl;
>
> and the error is:
>
> ex_07-03.cpp:32: error: expected unqualified-id before '(' token
>
Don't output it, just use the assert to validate your test. If the
assertion fails, your program will abort with an error message.

--
Ian Collins.

On Aug 9, 11:59 am, arnuld <geek.arn...@gmail.com> wrote:

> i did use that, now i just modified it to:
>
> std::cout << std::assert( raise_power(i, j) == mult_result )
> << std::endl;
>
> and the error is:
>
> ex_07-03.cpp:32: error: expected unqualified-id before '(' token
>
> what now ?

ok i got it. "assert" is a preprocessor-macro that does not return
anything and hence causes conflict with the overloaded operator "<<"

but then i have to write more-code:

assert( raise_power(i, j) == mult_result );
std::cout << ( raise_power(i, j) == mult_result ) << std::endl;

but then, is writing more code a good idea ? (when i know that
expression works fine)

arnuld wrote:
> On Aug 9, 11:59 am, arnuld <geek.arn...@gmail.com> wrote:
>
>> i did use that, now i just modified it to:
>>
>> std::cout << std::assert( raise_power(i, j) == mult_result )
>> << std::endl;
>>
>> and the error is:
>>
>> ex_07-03.cpp:32: error: expected unqualified-id before '(' token
>>
>> what now ?
>
> ok i got it. "assert" is a preprocessor-macro that does not return
> anything and hence causes conflict with the overloaded operator "<<"
>
> but then i have to write more-code:
>
> assert( raise_power(i, j) == mult_result );
> std::cout << ( raise_power(i, j) == mult_result ) << std::endl;
>
> but then, is writing more code a good idea ? (when i know that
> expression works fine)
>
No, the point was if your test passes, the program exits cleanly, if it
fails it aborts and you get an error message.

you could just write

assert( raise_power(i, j) == mult_result );
std::cout << "OK" << std::endl;

You can add more assertions,

assert( raise_power(2, 2) == 4 );

and so on.

I had assumed your book would have covered assert!

--
Ian Collins.