«

CoL wrote:

> You also try recursion for the same....
>
> ~col

To count bits? You're not in the business of performance eh?

Harald van D?k wrote:
>
> CBFalconer wrote:
> > Harald van D?k wrote:
> > > wrote:
> > >
> > >> On 32-bit platform, I am working on getting how many bits equal
> > >> to 1 without an if loop.
> > >
> > > Use a for loop or a while loop, testing each bit until you have
> > > no more bits to test. I'm not sure what an if loop would be like,
> > > unless you're using goto.
> >
> > I have no idea what an 'if loop' is.
> > [example]
> > which doesn't care how wide an int is.
>
> And the way I mentioned does?
>
> count = value < 0;
> for (bit = 1; bit < INT_MAX / 2; bit *= 2)
> if (value & bit)
> count++;
>
> It accepts ints of any width.

But it needs to know the precise type. My version will work when
fed bytes, longs, shorts, etc. (with matching changes in the type
of value, but making value an unsigned long will cover them all,
except long long which may or may not be available).

I find code fragments that need no editing more useful.
--
<http://www.cs.auckland.ac.nz/~pgut001/pubs/vista_cost.txt>
<http://www.securityfocus.com/columnists/423>

"A man who is right every time is not likely to do very much."
-- Francis Crick, co-discover of DNA
"There is nothing more amazing than stupidity in action."
-- Thomas Matthews

CBFalconer wrote:

> But it needs to know the precise type. My version will work when
> fed bytes, longs, shorts, etc. (with matching changes in the type
> of value, but making value an unsigned long will cover them all,
> except long long which may or may not be available).
>
> I find code fragments that need no editing more useful.

What's wrong with the typical straightforward way?

int bs(unsigned long v)
{
int c;

for (c = 0; v; v >>= 1)
c += v & 1;

return c;
}

CBFalconer wrote:
> Harald van D?k wrote:
> >
> > CBFalconer wrote:
> > > Harald van D?k wrote:
> > > > wrote:
> > > >
> > > >> On 32-bit platform, I am working on getting how many bits equal
> > > >> to 1 without an if loop.
> > > >
> > > > Use a for loop or a while loop, testing each bit until you have
> > > > no more bits to test. I'm not sure what an if loop would be like,
> > > > unless you're using goto.
> > >
> > > I have no idea what an 'if loop' is.
> > > [example]
> > > which doesn't care how wide an int is.
> >
> > And the way I mentioned does?
> >
> > count = value < 0;
> > for (bit = 1; bit < INT_MAX / 2; bit *= 2)
> > if (value & bit)
> > count++;
> >
> > It accepts ints of any width.
>
> But it needs to know the precise type. My version will work when
> fed bytes, longs, shorts, etc. (with matching changes in the type
> of value, but making value an unsigned long will cover them all,
> except long long which may or may not be available).
>
> I find code fragments that need no editing more useful.

Your version will not work with signed types, and the version for
unsigned types I posted later does not need editing either, as long as
the type of 'bit' is large enough.

Christopher Layne wrote:
> CBFalconer wrote:
>
>> But it needs to know the precise type. My version will work when
>> fed bytes, longs, shorts, etc. (with matching changes in the type
>> of value, but making value an unsigned long will cover them all,
>> except long long which may or may not be available).
>>
>> I find code fragments that need no editing more useful.
>
> What's wrong with the typical straightforward way?
>
> int bs(unsigned long v)
> {
> int c;
>
> for (c = 0; v; v >>= 1)
> c += v & 1;
> return c;
> }

Nothing that I can see. It will take more cycles, for each 0 bit
to the right of any 1 bit.

--
<http://www.cs.auckland.ac.nz/~pgut001/pubs/vista_cost.txt>
<http://www.securityfocus.com/columnists/423>

"A man who is right every time is not likely to do very much."
-- Francis Crick, co-discover of DNA
"There is nothing more amazing than stupidity in action."
-- Thomas Matthews

http://graphics.stanford.edu/~seander/bithacks.html


--
R.N.

wrote:
>
> On 32-bit platform,
> I am working on getting how many bits equal to 1 without an if loop.

unsigned bit_count(unsigned n)
{
unsigned count;

for (count = 0; n != 0; n &= n - 1) {
++count;
}
return count;
}

--
pete

On Feb 16, 5:01 am, Christopher Layne <cla...@com.anodized> wrote:
> CoL wrote:
> > You also try recursion for the same....
>
> > ~col
>
> To count bits? You're not in the business of performance eh?

Should perform just as well with proper optimizations:

static int
bits_r (unsigned int u, int count)
{
return !u ? count : bits_r(u & u-1, count+1);
}

int
bits (unsigned int u)
{
return bits_r(u, 0);
}

-- James

CBFalconer wrote:
> Harald van D?k wrote:
> > wrote:
> >
> >> On 32-bit platform, I am working on getting how many bits equal
> >> to 1 without an if loop.
> >
> > Use a for loop or a while loop, testing each bit until you have
> > no more bits to test. I'm not sure what an if loop would be like,
> > unless you're using goto.
>
> I have no idea what an 'if loop' is.
>
> unsigned int value, count;
>
> value = whatever;
> count = 0;
>
> /* loop invariant: count + bitsinvalue = bitsinwhatever */
> while (value) {
> count++;
> value = (value - 1) & value;
> }
> /* bitsinvalue = 0 */
>
> which doesn't care how wide an int is.

this is an interview question.

i = 0;
while(var)
{
var &= ~(-var);
i++;
}

dick wrote:
> CBFalconer wrote:
>> Harald van D?k wrote:
>>> wrote:
>>>
>>>> On 32-bit platform, I am working on getting how many bits equal
>>>> to 1 without an if loop.
>>>
>>> Use a for loop or a while loop, testing each bit until you have
>>> no more bits to test. I'm not sure what an if loop would be like,
>>> unless you're using goto.
>>
>> I have no idea what an 'if loop' is.
>>
>> unsigned int value, count;
>>
>> value = whatever;
>> count = 0;
>>
>> /* loop invariant: count + bitsinvalue = bitsinwhatever */
>> while (value) {
>> count++;
>> value = (value - 1) & value;
>> }
>> /* bitsinvalue = 0 */
>>
>> which doesn't care how wide an int is.
>
> this is an interview question.
>
> i = 0;
> while(var)
> {
> var &= ~(-var);
> i++;
> }

Doesn't work. Consider overflow (-var, for var == INT_MIN, 2'
complement), sign-magnitude representation, 1's complement
representation.

--
<http://www.cs.auckland.ac.nz/~pgut001/pubs/vista_cost.txt>
<http://www.securityfocus.com/columnists/423>

"A man who is right every time is not likely to do very much."
-- Francis Crick, co-discover of DNA
"There is nothing more amazing than stupidity in action."
-- Thomas Matthews