«

I have a few questions but first here is my code.

public class CountVowels
{
public static void main(String[] args)
{
int vowel = 0;
int i;
char pos;
String String1 = "Event Handlers is dedicated to making your
event a most memorable one.";
int length = String1.length();
for(i = 0; i < length - 1 ; i++);
{
pos = String1.charAt(i);
if (pos == 'A' || pos == 'a' || pos == 'E' || pos == 'e' ||
pos == 'I' || pos == 'i' || pos == 'O' || pos == 'o' || pos == 'U' ||
pos == 'u') {
vowel += 1;
}
}
System.out.println("There are " + vowel + " vowels in this
String");
}
}

Question one is why does String1.length() return 70 when there are
only 69 chars. Second question is why does this code not count the
vowels in the String.

Thanks in advance

Robert

BlackJackal wrote:
> I have a few questions but first here is my code.
>
> public class CountVowels
> {
> public static void main(String[] args)
> {
> int vowel = 0;
> int i;
> char pos;
> String String1 = "Event Handlers is dedicated to making your
> event a most memorable one.";
> int length = String1.length();
> for(i = 0; i < length - 1 ; i++);
> {
> pos = String1.charAt(i);
> if (pos == 'A' || pos == 'a' || pos == 'E' || pos == 'e' ||
> pos == 'I' || pos == 'i' || pos == 'O' || pos == 'o' || pos == 'U' ||
> pos == 'u') {
> vowel += 1;
> }
> }
> System.out.println("There are " + vowel + " vowels in this
> String");
> }
> }
>
> Question one is why does String1.length() return 70 when there are
> only 69 chars. Second question is why does this code not count the
> vowels in the String.
>
> Thanks in advance
>
> Robert
>

You still can't count and the problem is in the for loop!

--

Knute Johnson
email s/nospam/knute/

BlackJackal wrote:
> I have a few questions but first here is my code.
>
> public class CountVowels
> {
> public static void main(String[] args)
> {
>
[snip]

Didn't you just post this very same question 20 mins ago?
Hint: newsgroup posts don't always appear immediately. Give it at least
a couple of hours before assuming your message may have gone astray.
Annoying, I know....

Your counting is off. And is you bothered to check your for-loop with the
syntax you'd probably locate the error.

Oh and you should really consider replacing the if x || y || z.... with a
switch. It clutters the code otherwise.

cp schrieb:
> Oh and you should really consider replacing the if x || y || z.... with a
> switch. It clutters the code otherwise.
>
>
In fact, I'd replace the whole if/switch thing with a simple

String vowels = "aAeEoOuU";

if ( vowels.indexOf(pos) != -1 )

or with a Map or ...

Bye
Michael

Michael Rauscher schrieb:
> cp schrieb:
>> Oh and you should really consider replacing the if x || y || z....
>> with a switch. It clutters the code otherwise.
>>
> In fact, I'd replace the whole if/switch thing with a simple
>
> String vowels = "aAeEoOuU";

Which would be wrong, use

String vowels = "aAeEIiOoUu";

instead

Bye
Michael

Michael Rauscher wrote:
> Which would be wrong, use
>
> String vowels = "aAeEIiOoUu";
>
> instead

"ÀÃ*Ã�áÂâÃãÄäÅåÆæÈèÉéÊêËëÌìÃ�Ã*ÃŽ îÃ�ïÒòÓóÔôÕõÖöÙùÚúÛûÜüÃ�ýÅ�Å‚ ŒœαεΗηΥυΩωЮюий×�וי" ...

- Lew

Lew schrieb:
> Michael Rauscher wrote:
>> Which would be wrong, use
>>
>> String vowels = "aAeEIiOoUu";
>>
>> instead
>
> "ÀÃ*Ã�áÂâÃãÄäÅåÆæÈèÉéÊêËëÌìÃ�Ã*ÃŽ îÃ�ïÒòÓóÔôÕõÖöÙùÚúÛûÜüÃ�ýÅ�Å‚ ŒœαεΗηΥυΩωЮюий×�וי" ...

OP:

if (pos == 'A' || pos == 'a' || pos == 'E' || pos == 'e' ||
pos == 'I' || pos == 'i' || pos == 'O' || pos == 'o' || pos == 'U' ||
pos == 'u')

==>

"ÀÃ*Ã�áÂâÃãÄäÅåÆæÈèÉéÊêËëÌìÃ�Ã*ÃŽ îÃ�ïÒòÓóÔôÕõÖöÙùÚúÛûÜüÃ�ýÅ�Å‚ ŒœαεΗηΥυΩωЮюий×�וי" ?!?



Bye
Michael

On Wed, 31 Jan 2007 21:34:26 -0800, Michael Rauscher <>
wrote:
> cp schrieb:
>
>> Oh and you should really consider replacing the if x || y || z.... with
>> a switch. It clutters the code otherwise.
>In fact, I'd replace the whole if/switch thing with a simple
>
> String vowels = "aAeEoOuU";

And sometimes i?

I'd also declare it like this:

final String VOWELS = "aeiouAEIOU";

> if ( vowels.indexOf(pos) != -1 )
[sNip]

The reason I'd re-order the variables to begin with lower-case is for
efficiency since words are almost always mostly made up of combinations of
lower-case letters, but of course the application of this must also be
considered. Anyway, by placing the more commonly used variations first,
fewer iterations by the String.indexOf() method are required, and the
application works just a tiny bit faster as a result.

Now, with that in mind, if this little search is being used repeatedly in
a loop, then the benefits of such optimizations become more clear. With
regards to optimization, one may wish to also investigate the possibility
that "e" may be more common than "a" or that some other order would be
better suited.

--
Randolf Richardson - kingpin+
The Lumber Cartel, local 42 (Canadian branch)
http://www.lumbercartel.ca/