«

hi guys,
what is the best way to write a byte array to a file?
thanks a lot,bye

public void writeFile(byte[] data, String fileName) throws IOException{
OutputStream out = new FileOutputStream(fileName);
out.write(data);
out.close();
}
andrewzzz wrote:
> hi guys,
> what is the best way to write a byte array to a file?
> thanks a lot,bye

andrewzzz wrote:
> hi guys,
> what is the best way to write a byte array to a file?

This question screams for a how-to-make-a-rat-pie recipe type of an answer. So,
without further ado...

1. First you have to obtain those bytes. The best way is to read them from a file:

File file = new File("afile");
InputStream in = new FileInputStream(file);
byte[] bytes = new byte[file.length()];
in.read(bytes);
in.close();

//Exception handling is left to a gentle reader.

2. Now write them to a file.

Simple, heh?


For other not-so-best ways you can also resort to

http://java.sun.com/docs/books/tutorial/essential/io/

or, if the going gets extremely tough,

http://www.just****inggoogleit.com/s...le+io+tutorial

Ta ta!

Paul Davis wrote:
> public void writeFile(byte[] data, String fileName) throws IOException{
> OutputStream out = new FileOutputStream(fileName);
try {
> out.write(data);
} finally {
> out.close();
}
> }
> andrewzzz wrote:
>> hi guys,
>> what is the best way to write a byte array to a file?
>> thanks a lot,bye

Tom Hawtin

M.J. Dance wrote:
> InputStream in = new FileInputStream(file);
> byte[] bytes = new byte[file.length()];
> in.read(bytes);
> in.close();

Are you sure you don't want to check the return value of read, or use
another method from a decorator?

> or, if the going gets extremely tough,
>
> http://www.just****inggoogleit.com/s...le+io+tutorial

There's a lot of really bad advice on the web. Er, and on Usenet. Oh and
in books too.

Tom Hawtin

M.J. Dance wrote:

> byte[] bytes = new byte[file.length()];
> in.read(bytes);

/NEVER/ do that. Never !

(There are other problems with the code too, but that one is unforgivable, even
for throwaway code).

-- chris

Chris Uppal wrote:
> M.J. Dance wrote:
>
>>byte[] bytes = new byte[file.length()];
>>in.read(bytes);
>
> /NEVER/ do that. Never !

It should be replaced by something like this:

byte[] bytes = new byte[file.length()];
for (int n = 0, x; n < bytes.length; n += x ) {
x = in.read(bytes, n, bytes.length - n);
if (x < 0)
throw new EOFException("stream shorter than expected");
}

--
Thomas

>> M.J. Dance wrote:
>>>byte[] bytes = new byte[file.length()];
>>>in.read(bytes);

>Chris Uppal wrote:
>> /NEVER/ do that. Never !

Thomas Fritsch <> wrote:
>It should be replaced by something like this:
>
> byte[] bytes = new byte[file.length()];
> for (int n = 0, x; n < bytes.length; n += x ) {
> x = in.read(bytes, n, bytes.length - n);
> if (x < 0)
> throw new EOFException("stream shorter than expected");
> }

As long as you're checking for files that got shorter between creating your
byte array and actually reading, you might want to check that it got longer
with in.available() or just by reading another byte and seeing if one's there.

Alternately, you may prefer to just read whatever you can and not trust the
file.length() call at all. This works even if you're not reading from a file
(like from getResourceAsStream() or a network stream).

// best-guess starting size, make it up if we don't have a file.
ByteArrayOutputStream baos = new ByteArrayOutputStream(file.length());
byte[] buf = new byte[1024]; // read up to 1k at a time
boolean done=false;
while (!done) {
int amtRead = in.read(buf);
if (amtRead == -1) {
done = true; // EOF
} else {
baos.write(buf, 0, amtRead);
}
}
byte[] bytes = baos.toByteArray();
--
Mark Rafn <http://www.dagon.net/>