Velocity Reviews > Perl > Fibonacci problem

# Fibonacci problem

Brett Trost
Guest
Posts: n/a

 01-22-2004
OK, I wanted to make a recursive fibonacci method in Perl, and I can't
understand why it is not working, especially since I wrote the exact
same thing in Java and it works. Here's the perl code:

#!/usr/bin/perl
sub fib {
\$num = shift;
return 0 if \$num == 1;
return 1 if \$num == 2;
return fib(\$num - 1) + fib(\$num - 2);
}

print fib(\$ARGV[0]);

And here's the Java code:

class fib
{
public static void main(String[] args)
{
System.out.println(fib(Integer.parseInt(args[0])));
}

static int fib(int x) {
if (x == 1) return 0;
if (x == 2) return 1;
return fib(x - 1) + fib(x - 2);
}
}

The perl one keeps on running forever. If I print out \$num, it goes
rapidly into the negatives. Why is this, when the base case should
take care of that, and the Java code has the exact same logic and
works?! It must be an error with my Perl, but I can't find it.
Thanks for any help.

Jürgen Exner
Guest
Posts: n/a

 01-22-2004
Brett Trost wrote:
> OK, I wanted to make a recursive fibonacci method in Perl, and I can't
> understand why it is not working, especially since I wrote the exact
> same thing in Java and it works. Here's the perl code:
>
> #!/usr/bin/perl

There is a "use strict;" missing here ...

> sub fib {
> \$num = shift;

....which would have told you that \$num requires a declaration.
You are using the _global_ variable \$num, not a variable that is local to
the sub.

> return 0 if \$num == 1;
> return 1 if \$num == 2;
> return fib(\$num - 1) + fib(\$num - 2);
> }

jue

lesley_b_linux@yahoo.co.yuk
Guest
Posts: n/a

 01-22-2004
http://www.velocityreviews.com/forums/(E-Mail Removed) (Brett Trost) writes:

> OK, I wanted to make a recursive fibonacci method in Perl, and I can't
> understand why it is not working, especially since I wrote the exact
> same thing in Java and it works. Here's the perl code:
>
> #!/usr/bin/perl
> sub fib {
> \$num = shift;
> return 0 if \$num == 1;
> return 1 if \$num == 2;
> return fib(\$num - 1) + fib(\$num - 2);
> }
>
> print fib(\$ARGV[0]);
>

<snip>

> The perl one keeps on running forever. If I print out \$num, it goes
> rapidly into the negatives. Why is this, when the base case should
> take care of that, and the Java code has the exact same logic and
> works?! It must be an error with my Perl, but I can't find it.
> Thanks for any help.

I put in

#! /usr/bin/perl -w

at the start and debugged ....
../test.pl 8
Deep recursion on subroutine "main::fib" at ./test.pl line 7.

#! /usr/bin/perl -w
use strict;

and using

my \$num = shift;

gives the right results.

hth

Lesley

---

email address munged : remove relevant y if nec.

 Posting Rules You may not post new threads You may not post replies You may not post attachments You may not edit your posts BB code is On Smilies are On [IMG] code is On HTML code is OffTrackbacks are On Pingbacks are On Refbacks are Off Forum Rules

 Similar Threads Thread Thread Starter Forum Replies Last Post dleecurt@cc.usu.edu C++ 28 06-05-2011 04:30 AM tphyahoo Ruby 6 08-08-2008 08:15 PM Lance C++ 5 12-02-2003 09:17 AM Alex Vinokur C++ 0 10-29-2003 12:07 PM fighterman19 C++ 11 09-08-2003 02:30 PM