Velocity Reviews - Computer Hardware Reviews

Velocity Reviews > Newsgroups > Programming > Java > Code review requested

Reply
Thread Tools

Code review requested

 
 
Ian Pilcher
Guest
Posts: n/a
 
      12-15-2003
I have created a class which extends BufferedInputStream and allows me
to turn off the buffering functionality. I'm pretty new to Java
programming, and I'm a little uncomfortable mucking about with the
internals of one of the API classes -- even though I've done my best to
rely only on the documented behavior of BufferedInputStream.

I'm hoping someone with a little more experience will take a couple of
minutes to look over the code at

http://home.comcast.net/~i.pilcher/T...putStream.java

and let me know if I've made any really glaring errors.

If anyone wants to compile the code, you'll also need

http://home.comcast.net/~i.pilcher/S...Exception.java

I've taken the "brute force" approach of making every public method
synchronized; I'd be interesting in hearing if there are any places
where this may not be necessary.

Finally, if anyone has any suggestions for better (shorter) class names,
I'd love to hear them.

Thanks!
--
================================================== ======================
Ian Pilcher
================================================== ======================

 
Reply With Quote
 
 
 
Reply

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are On
Pingbacks are On
Refbacks are Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
Code Review requested: Postscript Interpreter luserXtrog C Programming 21 01-01-2011 11:46 PM
A little light code review requested luserXtrog C Programming 2 08-18-2010 04:15 AM
Re: Code review requested, Accelerated C++ Vyacheslav Kononenko C++ 0 10-18-2004 01:58 PM
Re: Code review requested, Accelerated C++ Mike Wahler C++ 1 10-18-2004 03:43 AM
Code review requested Ed Java 1 07-19-2004 12:11 PM



Advertisments
 



1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57