Velocity Reviews

Velocity Reviews (
-   Python (
-   -   Re: accepting file path or file object? (

Cameron Simpson 11-05-2012 09:58 PM

Re: accepting file path or file object?
On 05Nov2012 10:54, andrea crotti <> wrote:
| Quite often I find convenient to get a filename or a file object as
| argument of a function, and do something as below:

I tend to do this:

def f(fp):
if isinstance(fp, str):
with open(fp) as subfp:
return f(subfp)
... main code using fp as file object ...

That solves the file close issue neatly and lets you put this stuff up
the top where it is obvious.

| So I'm thinking if it's not just worth to skip the support for file
| objects and only use the filenames, which seems a more robust and
| consistent choice..

You can't always use filenames; plenty of calling code will already have
a file-like object to hand (eg a HTTP response or a StringIO or an
already opened file or any of a million other things). So requiring
filenames all the time is unreasonable.

It is almost always etter to write for file objects, since that is what
you would be converting any passed filename into, and put a self call at
the top to convert a filename into a file object if that is a reasonable
use case in your app.

Cameron Simpson <>

....valve spreeengs? VALVE _*SPREEEEEEEEENGS*_!?! We don' neeeed
no steeeenking valve spreeeeeengs!... - Dr. Desmo

All times are GMT. The time now is 04:10 AM.

Powered by vBulletin®. Copyright ©2000 - 2014, vBulletin Solutions, Inc.
SEO by vBSEO ©2010, Crawlability, Inc.