Velocity Reviews

Velocity Reviews (http://www.velocityreviews.com/forums/index.php)
-   Java (http://www.velocityreviews.com/forums/f30-java.html)
-   -   static initializer not working (http://www.velocityreviews.com/forums/t945581-static-initializer-not-working.html)

mike 04-20-2012 12:10 PM

static initializer not working
 
Hi,


I cannot get my registration of parser to work. When try to make a
call to get the registered parser:

PullParserFactory.instance().createParser(type);

I get a NullPointerException. When I debug I can see that the HashMap
is empty.

What am I missing?

br,

//mike

public class FindBugsParser implements AbstractPullParser{

// Register with Factory
static {
PullParserFactory.instance().registerParser(Plugin Impl.FINDBUGS,
new FindBugsParser());
}

public AbstractPullParser createParser() {
return new FindBugsParser();
}

}

public final class PullParserFactory {

/**
* Single instance created upon class loading.
*/
private static PullParserFactory INSTANCE = new PullParserFactory();

private static final HashMap<String, AbstractPullParser>
registeredParsers = new HashMap<String, AbstractPullParser>();

//no outside access.
private PullParserFactory() {

}

public static PullParserFactory instance() {
return INSTANCE;
}

public void registerParser(String type, AbstractPullParser parser) {
registeredParsers.put(type, parser);
}

public AbstractPullParser createParser(String type) {

return (AbstractPullParser) registeredParsers.get(type);
}

}




Eric Sosman 04-20-2012 12:42 PM

Re: static initializer not working
 
On 4/20/2012 8:10 AM, mike wrote:
> Hi,
>
>
> I cannot get my registration of parser to work. When try to make a
> call to get the registered parser:
>
> PullParserFactory.instance().createParser(type);
>
> I get a NullPointerException. When I debug I can see that the HashMap
> is empty.
>
> What am I missing?


My hunch is that nothing has caused the FindBugsParser class to
be initialized at the time you make your call and get the NPE:

- The HashMap is initially empty, and gets populated by calls
to registerParser().

- The only (visible) call to registerParser() occurs during the
initialization of FindBugsParser.

- So if FindBugsParser has not yet been initialized at the time
of the call to instance(), the HashMap will still be empty and
instance() will return null.

The fact that FindBugsParser.class is hanging around somewhere in
your class path is not enough to make Java load and initialize it;
Java won't load the class until it sees a need for it.

> br,
>
> //mike
>
> public class FindBugsParser implements AbstractPullParser{
>
> // Register with Factory
> static {
> PullParserFactory.instance().registerParser(Plugin Impl.FINDBUGS,
> new FindBugsParser());
> }
>
> public AbstractPullParser createParser() {
> return new FindBugsParser();
> }
>
> }
>
> public final class PullParserFactory {
>
> /**
> * Single instance created upon class loading.
> */
> private static PullParserFactory INSTANCE = new PullParserFactory();
>
> private static final HashMap<String, AbstractPullParser>
> registeredParsers = new HashMap<String, AbstractPullParser>();
>
> //no outside access.
> private PullParserFactory() {
>
> }
>
> public static PullParserFactory instance() {
> return INSTANCE;
> }
>
> public void registerParser(String type, AbstractPullParser parser) {
> registeredParsers.put(type, parser);
> }
>
> public AbstractPullParser createParser(String type) {
>
> return (AbstractPullParser) registeredParsers.get(type);
> }
>
> }
>
>
>



--
Eric Sosman
esosman@ieee-dot-org.invalid


All times are GMT. The time now is 06:12 AM.

Powered by vBulletin®. Copyright ©2000 - 2014, vBulletin Solutions, Inc.
SEO by vBSEO ©2010, Crawlability, Inc.